cvs commit: src/sys/contrib/pf/net if_pflog.c if_pflog.hif_pfsync.c if_pfsync.h pf.c pf_ioctl.c pf_norm.c pf_osfp.c pf_table.c pfvar.h src/sys/contrib/pf/netinet in4_cksum.c

[Andre Oppermann]

Tim Robbins wrote:
> 
> On Wed, Feb 25, 2004 at 10:01:26PM -0800, Steve Kargl wrote:
> 
> > On Wed, Feb 25, 2004 at 06:34:13PM -0800, Max Laier wrote:
> > > mlaier      2004/02/25 18:34:12 PST
> > >
> > >   FreeBSD src repository
> > >
> > >   Modified files:
> > >     sys/contrib/pf/net   if_pflog.c if_pflog.h if_pfsync.c
> > >                          if_pfsync.h pf.c pf_ioctl.c pf_norm.c
> > >                          pf_osfp.c pf_table.c pfvar.h
> > >     sys/contrib/pf/netinet in4_cksum.c
> > >   Log:
> > >   Bring diff from the security/pf port. This has code been tested as a port
> > >   for a long time and is run in production use. This is the code present in
> > >   portversion 2.03 with some additional tweaks.
> > >
> > >   The rather extensive diff accounts for:
> > >    - locking (to enable pf to work with a giant-free netstack)
> > >    - byte order difference between OpenBSD and FreeBSD for ip_len/ip_off
> > >    - conversion from pool(9) to zone(9)
> > >    - api differences etc.
> > >
> > >   Approved by: bms(mentor) (in general)
> > >
> >
> > Was this import discussed on arch@ or current@?  We now have ipfw, ipfilter,
> > and pf in the base system.  How many more firewall packages are we going
> > to import into the base system?  Are you going to remove ipfw or ipfilter?
> > Is there a NO_PF make.conf knob?
> 
> You forgot about ip6fw. I agree that having 4 firewalls in the base system
> is somewhat excessive, but not importing pf is not a solution to the
> problem of having too many firewalls. What I'd like to see is ipfw,
> ipfilter and ip6fw implemented in terms of the pf kernel code, then
> eventually phased out after a few releases. With the exception of dummynet,
> this should be fairly straightforward.

Ick, please leave ipfw2 in there, I like it much more than pf (especially
syntax).

If you are going to nuke something then hit ipfilter.  It's not really
being maintained and not even the current main version.  pf pretty much
replaces ipfilter people say.

> If you're worried about the size of the base system, there are plenty
> of other rarely-used features that could be removed to "make room" for pf.

-- 
Andre