cvs commit: src/gnu/usr.bin/binutils/gasp Makefile src/gnu/usr.bin/binutils/gdb Makefile src/gnu/usr.bin/cvs/cvs Makefile src/gnu/usr.bin/cvs/lib Makefile src/gnu/usr.bin/cvs/libdiff Makefile src/gnu/usr.bin/diff Makefile src/gnu/usr.bin/grep Makefile

[Andrey Chernov]

On Wed, Feb 18, 2004 at 09:02:55PM +0200, Ruslan Ermilov wrote:
> This is bogus.  The correct way would be to fix #include's to
> spell ``#include <gnu/regex.h>'', but this will be considered
> evil as it will take lot of files off their vendor branches.

Yes, and it was the reason of commit to NOT do it, using -I
instead.

> What was wrong with ${.CURDIR}/.../include/gnu, except
> misspelling the number of ".."'s in some cases?

The reason is that ${.CURDIR}/.... is for _source_ dir, not for final
${DESTDIR} where includes are installed at the start of 'make world'.
There is no regex.h in source dir with that name. To make it works,
there must be -I${.CURDIR}/.../gnu/lib/libregex insead, but too many ../ 
are ugly in anycase.

> I've been slowly working towards removing all instances of
> -I${DESTDIR}/usr/include/... in the src/ makefiles.  Before
> this commit, there were only a few makefiles with
> -I${DESTDIR}/usr/include/rpcsvc, but RPC code is known to be
> a nightmare to deal with.

I am not sure it will be right, only if ${.CURDIR} is in the same place, 
where ${DESTDIR} is.

-- 
Andrey Chernov | http://ache.pp.ru/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 305 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20040218/c6c7ec5e/attachment.bin