cvs commit: src/sys/alpha/alpha support.s src/sys/i386/i386
swtch.s src/sys/kern kern_shutdown.c src/sys/sys systm.h
eivind at FreeBSD.org
Tue Feb 17 07:30:54 PST 2004
On Fri, Feb 13, 2004 at 04:02:46AM +1100, Bruce Evans wrote:
> On Tue, 20 Jan 2004, Bruce Evans wrote:
> > On Mon, 19 Jan 2004, Poul-Henning Kamp wrote:
> > > phk 2004/01/19 13:27:11 PST
> > >
> > > FreeBSD src repository
> > >
> > > Modified files:
> > > sys/alpha/alpha support.s
> > > sys/i386/i386 swtch.s
> > > sys/kern kern_shutdown.c
> > > sys/sys systm.h
> > > Log:
> > > Add linenumber and source filename to panic(9) output.
> > This was rejected in all reviews. It gives less information than
> > grepping the sources, at some cost (grep at least gives correct line
> > numbers when the sources don't quite match the binary).
> > Please back this out.
> I'm still waiting for this to be backed out.
> I just found yet another bug in it: it defeats simple regression checks.
> Suppose you make some cosmetic changes that add a line before a panic.
> This now changes the object file even when the file is compiled without
This means file and line info HAS to be possible to disable, and should
(IMO) be off in LINT.
When I worked actively on the kernel, I regularly used the object file
comparison technique. The technique is extremely useful to test various
cleanups, and even before the changed panic() messages a few log
messages that included __FILE__ and __LINE__ got in the way from time to
More information about the cvs-src