cvs commit: src/kerberos5/lib/libroken Makefile

[Ruslan Ermilov]

On Tue, Feb 03, 2004 at 06:18:44PM +0100, Dag-Erling Sm?rgrav wrote:
> Andre Oppermann <andre at freebsd.org> writes:
> > I'm not a perl hacker so I can't really comment on the code snipped
> > below but it looks strange that the first $ENV{} has the environment
> > variable name in "" and the second one in '' quotes.
> 
> this has no significance.
> 
> >  # The username of the committer.
> >  $COMMITTER = $ENV{"LOGNAME"} || $ENV{'USER'} || getlogin
> >  		|| (getpwuid($<))[0] || sprintf("uid#%d",$<);
> 
> This should be
> 
> $COMMITTER = $ENV{'CVS_USER'} ||
>     die("Not invoked by CVS!\n");
> 
Isn't CVS_USER defined only in pserver?


Cheers,
-- 
Ruslan Ermilov
FreeBSD committer
ru at FreeBSD.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20040203/ddb23984/attachment-0001.bin