cvs commit: src/sys/kern vfs_bio.c src/sys/fs/nwfs nwfs_vnops.c src/sys/fs/smbfs smbfs_vnops.c

[Nate Lawson]

On Sat, 18 Oct 2003, Nate Lawson wrote:
> On Sat, 18 Oct 2003, Poul-Henning Kamp wrote:
> >   Modified files:
> >     sys/kern             vfs_bio.c
> >     sys/fs/nwfs          nwfs_vnops.c
> >     sys/fs/smbfs         smbfs_vnops.c
> >   Log:
> >   Convert some if(bla) panic("foo") to KASSERTS to improve grep-ability.
> >
> >   Revision  Changes    Path
> >   1.29      +1 -2      src/sys/fs/nwfs/nwfs_vnops.c
> >   1.41      +1 -2      src/sys/fs/smbfs/smbfs_vnops.c
> >   1.414     +2 -4      src/sys/kern/vfs_bio.c
> >
> >
> > Index: src/sys/fs/nwfs/nwfs_vnops.c
> > diff -u src/sys/fs/nwfs/nwfs_vnops.c:1.28 src/sys/fs/nwfs/nwfs_vnops.c:1.29
> > --- src/sys/fs/nwfs/nwfs_vnops.c:1.28	Sun Jun 15 11:52:58 2003
> > +++ src/sys/fs/nwfs/nwfs_vnops.c	Sat Oct 18 02:32:39 2003
> > @@ -799,8 +799,7 @@
> >  	KASSERT(ap->a_vp == ap->a_bp->b_vp, ("%s(%p != %p)",
> >  	    __func__, ap->a_vp, ap->a_bp->b_vp));
> >  	NCPVNDEBUG("\n");
> > -	if (bp->b_flags & B_PHYS)
> > -		panic("nwfs physio");
> > +	KASSERT(!(bp->b_flags & B_PHYS), ("nwfs physio"));
> >  	if (bp->b_flags & B_ASYNC)
> >  		td = (struct thread *)0;
> >  	else
>
> This removes sanity checks for the !INVARIANTS case (which all our
> releases are).
>
> -Nate

... and removed the check completely a few commits down.  Since it's part
of a larger strategy, I assume that has already been evaluated.  Forget
the previous email.

-Nate