cvs commit: src/lib/libufs bread.3 cgread.3 getino.3 libufs.3 sbread.3 ufs_disk_close.3

[Bruce Evans]

On Thu, 9 Oct 2003, Jacques A. Vidrine wrote:

> On Thu, Oct 09, 2003 at 02:45:20AM -0700, Hiten Pandya wrote:
> > hmp         2003/10/09 02:45:20 PDT
> >
> >   FreeBSD src repository (doc committer)
> >
> >   Modified files:
> >     lib/libufs           bread.3 cgread.3 getino.3 libufs.3
> >                          sbread.3 ufs_disk_close.3
> >   Log:
> >   Remove unneccessary include of sys/types.h in the SYNOPSIS
> >   header.
> >
> >   Sys/param.h includes sys/types.h internally unless LOCORE is
> >   defined.

Including both is also a style bug.

> I think you removed the wrong header.  Is <sys/param.h> required in
> each of these cases?  If not, then I believe the synopsis should refer
> only to <sys/types.h>:

<sys/param.h> is a prerequisite for <sys/mount.h> and some of the other
headers.  <sys/mount.h> is a prerequisite for <ufs/ufs/ufsmount.h>,
but the mount headers are not needed for much if anything in these
interfaces.  <sys/param.h> is only needed to define MAXBSIZE otherwise.

getino.3 might be more useful if it were installed.

Bruce