Checksum/copy

Bruce Evans bde at zeta.org.au
Fri Mar 28 18:42:06 PST 2003


On Fri, 28 Mar 2003, Peter Wemm wrote:

> Dag-Erling =?iso-8859-1?q?Sm=F8rgrav?= wrote:
> > David Malone <dwmalone at maths.tcd.ie> writes:
> > > On Thu, Mar 27, 2003 at 09:57:35AM +0100, des at ofug.org wrote:
> > > > Might it be a good idea to have separate b{copy,zero} implementations
> > > > for special purposes like pmap_{copy,zero}_page?
> > > We do have a i686_pagezero already, which seems to be used in
> > > pmap_zero_page - I guess it may not be well tuned to modern processors,
> > > as it is almost 5 years old.
> >
> > i686_pagezero uses 'rep stosl' after an initial 'rep scasl' to check
> > if the page was already zero (which is a pessimization unless we zero
> > a lot of pages that are already zeroed).  SSE can do far better than
> > that.
>
> i686_pagezero was written with SMP in mind.  The cache state ends up in
> a more favourable condition when sharing with other cpus.

Hmm.  The SMP advantage seems to be mainly a poor man's avoidance of
clobbering caches.  By writing only to cache lines that are are not all
zero, we avoid busting all on-CPU caches except the ones on the CPU
doing the zeroing.

This makes the main bug in i686_pagezero() even sillier.  We actually
write zeros to everything after the first nonzero word, so we only get
the cache benefit for cache lines up to the first not-all-zero one.

Bruce


More information about the cvs-src mailing list