cvs commit: src/sys/dev/ips ips.c ips.h ips_commands.c ips_pci.c

Nate Lawson nate at root.org
Thu Jun 26 10:12:08 PDT 2003


On Thu, 26 Jun 2003, John Baldwin wrote:
> Should be "hint.ips.0.disabled".  Perhaps we need to add a resource_disabled()
> function to abstract this so people stop getting it wrong.  Something like:

With you so far...

> You could then expand this function to check 'disable' as well if
> desired and allow for 'true' and 'false', 'on' and 'off' in addition
> to '0' and '1'.

...And then you lost me.  :)  I think that binary flags should only have
one way to set/clear them.  Adding options only increases confusion (i.e.
what about TRUE or yes/no)?  The int approach seems ok.

-Nate


More information about the cvs-src mailing list