cvs commit: src/etc Makefile src/etc/isdn Makefile

Bruce Evans bde at zeta.org.au
Mon Aug 18 19:59:32 PDT 2003


On Mon, 18 Aug 2003, David O'Brien wrote:

> On Mon, Aug 18, 2003 at 01:33:32PM +0900, Shin-ichi Yoshimoto wrote:
> > Subject: cvs commit: src/etc Makefile src/etc/isdn Makefile,
> > On Sun, 17 Aug 2003 17:36:31 -0700 (PDT), David E. O'Brien wrote:
> > >   1.10      +4 -2      src/etc/isdn/Makefile
> >
> > You forgot ".include <bsd.prog.mk>"
>
> Eeek, will fix.  But why not include <bsd.own.mk> instead?

Because <bsd.own.mk> is (mostly) an implementation detail.

Anyway, isdn/Makefile would need <bsd.prog.mk> if it were a BSD makefile.
Most of this bug suite is caused by isdn/Makefile using home made (and
wrong) install rules.  isdn/Makefile should look much like rc.d/Makefile
(with FILES, etc.) except it shouldn't have the style bug of including
<bsd.own.mk>.

There are a few other Makefile that include <bsd.own.mk> directly.  This
seems to be just a style bug except in src/Makefile.inc1.

Bruce


More information about the cvs-src mailing list