cvs commit: src/sys/contrib/dev/acpica acfreebsd.h

Daniel C. Sobral dcs at tcoip.com.br
Thu Aug 7 07:18:16 PDT 2003


Nate Lawson wrote:
> njl         2003/08/06 21:46:17 PDT
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/contrib/dev/acpica acfreebsd.h 
>   Log:
>   Add includes to fix user-compilation of acpica.  Also clarify a comment
>   about overriding the OS name.

This commit broke world on loader.

The problem is sys/boot/i386/libi386/biosacpi.c, which includes this 
file since your rev 1.5 commit. :-)

Specifically, stand.h, which is included by anything that uses libstand 
functions (such as is the case with biosacpi.c), is mutually exclusive 
with ctype.h.

Specifically:

/* Not building kernel code, so use libc */

is false on both accounts for loader. :-) Loader is not kernel, alright, 
but neither does it use libc.

Since I'm not familiar with how, exactly, is acfreebsd.h used, I can't 
offer more advise. :-)

Tricky, eh? :-)

Shouldn't ctype.h be a required include to anything including acfreebsd.h?

-- 
Daniel C. Sobral                   (8-DCS)
Gerencia de Operacoes
Divisao de Comunicacao de Dados
Coordenacao de Seguranca
VIVO Centro Oeste Norte
Fones: 55-61-313-7654/Cel: 55-61-9618-0904
E-mail: Daniel.Capo at tco.net.br
         Daniel.Sobral at tcoip.com.br
         dcs at tcoip.com.br

Outros:
	dcs at newsguy.com
	dcs at freebsd.org
	capo at notorious.bsdconspiracy.net

Old mail has arrived.



More information about the cvs-src mailing list