cvs commit: src/sys/dev/sym sym_fw.h

[David O'Brien]

On Tue, Aug 05, 2003 at 04:16:17PM +0300, Diomidis Spinellis wrote:
> > >   Log:
> > >   Remove extraneous semicolons.  They are already provided by
> > >   the macro definition, and cause the generation of syntactically
> > >   incorrect code that gcc happens to accept.
> > 
> > This is backwards.
> > >From style(9):
> >                                                       Any final statement-ter-
> >      minating semicolon should be supplied by the macro invocation rather than
> >      the macro, to make parsing easier for pretty-printers and editors.
> > 
> > Please consider reverting this and change the macros in the file to not
> > supply the terminating semicolon.
> 
> I would certainly follow the style(9) guide if the existing code allowed
> it.

Please realize that this driver is shared with other OS's.