cvs commit: src/sys/modules Makefile src/sys/pci if_en_pci.c midwayvar.h

[Harti Brandt]

On Sat, 26 Apr 2003, David O'Brien wrote:

DO>On Fri, Apr 25, 2003 at 09:14:03AM -0700, Hartmut Brandt wrote:
DO>>   Modified files:
DO>>     sys/modules          Makefile
DO>>     sys/pci              if_en_pci.c
DO>>     sys/dev/en           midway.c midwayreg.h midwayvar.h
DO>>   Added files:
DO>>     sys/modules/en       Makefile
DO>>   Log:
DO>>   Convert the midway driver to use busdma. Except for this conversion the
DO>>   following changes have been done:
DO>>
DO>>   - stylify. The original code was too hard to read.
DO>>   - get rid of a number of compilation options (Adaptec-only, Eni-only, no-DMA).
DO>>   - more debugging features.
DO>>   - locking. This is not correct yet in the absence of interface layer locking,
DO>
DO>Were you not aware we have rules against exactly this type of commit??
DO>It is totally impossible to tell what the real changes were and which the
DO>style changes were.  Please don't make a commits like this again.

All this stuff was ready before I got my commit bit. At that time I did
not care. After that, given that actually only a handful people care about
this driver, I thought that it makes not much sense to do the work twice
and factor out the style changes from the patch. I don't have another
patch of this kind, so don't be afraid...

harti
-- 
harti brandt,
http://www.fokus.fraunhofer.de/research/cc/cats/employees/hartmut.brandt/private
brandt at fokus.fraunhofer.de, harti at freebsd.org