cvs commit: src/sys/dev/wl if_wl.c

[John Baldwin]

On 16-Apr-2003 John Hay wrote:
> On Wed, Apr 16, 2003 at 02:06:25PM -0400, John Baldwin wrote:
>> 
>> On 16-Apr-2003 John Hay wrote:
>> > jhay        2003/04/16 10:42:38 PDT
>> > 
>> >   FreeBSD src repository
>> > 
>> >   Modified files:
>> >     sys/dev/wl           if_wl.c 
>> >   Log:
>> >   Add locking and remove all the spl() calls.
>> 
>> Note that some of the spl calls covered structures other than
>> just the softc.  I'd prefer that we leave spl calls in until
>> all the structures they cover are locked.
> 
> Ok, should I put them all back? Or just the ones being used as
> interrupt disablers? And what about the places where there
> should have been splx()es but weren't?

I would put back any spl's covering things not covered by the
locks you added. :)  Adding in missing spl's is not necessarily
required, so doing or not doing that is your choice.

-- 

John Baldwin <jhb at FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/