cvs commit: src/libexec/talkd announce.c extern.h print.c table.c talkd.c

[Ruslan Ermilov]

On Thu, Apr 03, 2003 at 06:04:25PM +1000, Bruce Evans wrote:
> On Wed, 2 Apr 2003, Marcel Moolenaar wrote:
> 
> > Please, everybody, do not set WARNS=5 on anything because it breaks
> > non-optimized builds:
> >
> > cc -g -mcpu=pentiumpro -I/usr/local/src/fpi/cpu/..   -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith
> > -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wcast-align -Wuninitialized  -c decode.c
> > cc1: warnings being treated as errors
> > cc1: warning: -Wuninitialized is not supported without -O
> > *** Error code 1
> 
> Too late:
> 
[...]
> This is mostly a bug in the implementation of WARNS.
> 
How's this bugfix?

%%%
Index: bsd.sys.mk
===================================================================
RCS file: /home/ncvs/src/share/mk/bsd.sys.mk,v
retrieving revision 1.12
diff -u -r1.12 bsd.sys.mk
--- bsd.sys.mk	31 Mar 2003 13:10:51 -0000	1.12
+++ bsd.sys.mk	3 Apr 2003 08:48:40 -0000
@@ -25,7 +25,7 @@
 .  if ${WARNS} > 3
 CFLAGS		+=	-Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wcast-align
 .  endif
-.  if ${WARNS} > 4
+.  if ${WARNS} > 4 && !empty(CFLAGS:M-O*) && empty(CFLAGS:M-O0)
 CFLAGS		+=	-Wuninitialized
 .  endif
 # BDECFLAGS
%%%


Cheers,
-- 
Ruslan Ermilov		Sysadmin and DBA,
ru at sunbay.com		Sunbay Software AG,
ru at FreeBSD.org		FreeBSD committer,
+380.652.512.251	Simferopol, Ukraine

http://www.FreeBSD.org	The Power To Serve
http://www.oracle.com	Enabling The Information Age
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20030403/2e6b2e53/attachment.bin