cvs commit: ports/games Makefile ports/games/drcreep Makefile distinfo pkg-descr pkg-plist

[Chris Rees]

On 30 Mar 2012 18:17, "Alex Kozlov" <spam at rm-rf.kiev.ua> wrote:
>
> On Fri, Mar 30, 2012 at 05:11:09PM +0000, Max Brazhnikov wrote:
> > On Fri, 30 Mar 2012 18:54:56 +0300, Alex Kozlov wrote:
> > > On Fri, Mar 30, 2012 at 03:40:39PM +0000, Max Brazhnikov wrote:
> > > > And by the way ${ECHO_CMD} should be used, if you really need echo.
> > > Do You mean ECHO_MSG?
> > It depends. The bsd.command.mk says:
> >
> > # ECHO is defined in /usr/share/mk/sys.mk, which can either be "echo",
> > # or "true" if the make flag -s is given.  Use ECHO_CMD where you mean
> > # the echo command.
> > ECHO_CMD?=    echo                            # Shell builtin
> >
> > # Used to print all the '===>' style prompts - override this to turn
them off.
> > ECHO_MSG?=    ${ECHO_CMD}
> But the Porters handbook says:
>
> Likewise, the distinction between ECHO_MSG and ECHO_CMD should be kept in
mind.
> The former is for printing informational text to the screen, while the
latter
> is for command pipelining.
>
> A good example for both can be found in shells/bash2/Makefile:
> update-etc-shells:
>        @${ECHO_MSG} "updating /etc/shells"
>        @${CP} /etc/shells /etc/shells.bak
>        @( ${GREP} -v ${PREFIX}/bin/bash /etc/shells.bak; \
>                ${ECHO_CMD} ${PREFIX}/bin/bash) >/etc/shells
>        @${RM} /etc/shells.bak
>

That is correct, ECHO_MSG is preferred for screen messages.

However, pkg-message is still more appropriate here :)

Chris