cvs commit: ports/www/resin3 Makefile distinfo pkg-plist ports/www/resin3/files install.sh patch-apache1-Makefile.in patch-apache2-Makefile.in patch-configure patch-resin.conf pkg-deinstall pkg-install pkg-message-advanced.in pkg-message.in ...

[Jason Helfman]

On Wed, Mar 14, 2012 at 11:36:48PM -0500, Doug Barton thus spake:
>At minimum this violates the rule about not adding new rc.d scripts with
>the .sh suffix. Please carefully read
>http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html,
>especially the pre-commit checklist. (Hint, there are other problems
>with these scripts. I suggest you read that web page and submit a patch
>to -rc@ or -ports@)
>
>It's also not clear to me what the %%APP_NAME%% stuff in resin3 is for,
>but I haven't looked at it deeply yet.

I've submitted an update proposal over to freebsd-rc@

Thanks, Doug!

-jgh
-- 
Jason Helfman         | FreeBSD Committer
jgh at FreeBSD.org       | http://people.freebsd.org/~jgh