cvs commit: ports/www/nginx Makefile ports/www/nginx/files nginx.sh.in ports/www/nginx-devel Makefile ports/www/nginx-devel/files nginx.sh.in

[Doug Barton]

On 06/12/2012 23:46, Sergey A. Osokin wrote:
> Hi Doug,
> 
> On Tue, Jun 12, 2012 at 11:36:43PM -0700, Doug Barton wrote:
>> Since it's only called in one place, there's no need to put the
>> directory code in a function. Also, instead of doing it in 3 steps you
>> can unconditionally use install as follows:
>>
>> install -d -o %%WWWOWN%% -g %%WWWGRP%% -m 755 ${_tmpprefix}
> 
> I do this at Makefile:
> ...
>         ${MKDIR} ${ETCDIR} ${NGINX_TMPDIR}
>         ${CHOWN} ${WWWOWN}:${WWWGRP} ${NGINX_TMPDIR}

You should not do that in the Makefile since it's worthless for
packages. Also, the rc.d script should always do whatever is necessary
to make the service work ... both for general purposes and for packages.

> Also, I do my changes in nginx.sh.in for tmpfs(5), could you look at
> http://www.freebsd.org/cgi/query-pr.cgi?pr=168836 for details.

Yes, doing this in the rc.d script is especially important for things in
/tmp since it's pretty common for it to start clean at boot time.

hth,

Doug

-- 

    This .signature sanitized for your protection