cvs commit: ports/multimedia/acidrip Makefile ports/math/algotutor Makefile ports/sysutils/apt Makefile ports/graphics/asciio Makefile ports/devel/autodia Makefile ports/www/awffull Makefile ports/devel/bazaar Makefile ports/www/bigbluebutton Mak

[Eitan Adler]

On Sun, Jan 22, 2012 at 5:11 PM, Olli Hauer <ohauer at freebsd.org> wrote:
> Hm, if I read the diffs Eitan has changed from `=' to `:=' so I think you mean
>  Why should we stop using `='?

A few people on portmgr expressed their preferences that we stop using
both = and := and instead duplicate contents of the variables. Instead
of continuing to guess their reasoning I'll let someone with a hat
reply :)

>>> Instead, we should fix portlint(1) to offer this obvious thing instead of
>>> duplicating two variables like it bogusly does now.
>>
>> The concern is that someone would add something extra to BUILD_DEPENDS
>> without thinking about it and thus add extra bogus RUN_DEPENDS. I'm
>> uncertain if there other additional reasons that portmgr dislikes :=
>
> It doesn't matter if you have RUN_DEPENDS=${BUILD_DEPENDS} or RUN_DEPENDS:=${BUILD_DEPENDS},
> if someone adds additional `something' to BUILD_DEPENDS then it is in both cases also in RUN_DEPENDS but `:=` preserves including additional dependencies from `something'.

This is why my commit unbreaks ports but it is unrelated to the point
I made at the end of my commit log.

> Maybe the following section in the PH will make things clearer.
> http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-depend.html#AEN2173

If I understand portmgr@ correctly this paragraph is bogus and should
read, "instead explicitly list the dependancies".

-- 
Eitan Adler
Source & Ports committer
X11, Bugbusting teams