cvs commit: ports/chinese/tin Makefile ports/chinese/tin/files patch-attrib.c patch-cook.c patch-init.c patch-mail.c patch-tin.defaults patch-tin_defaults

[Alexey Dokuchaev]

On Tue, Jan 03, 2012 at 10:31:37PM -0500, Sahil Tandon wrote:
> On Tue, 2012-01-03 at 15:54:38 +0000, Alexey Dokuchaev wrote:
> > ...
> > >   Revision  Changes    Path
> > >   1.1       +11 -0     ports/chinese/tin/files/patch-tin.defaults (new)
> > >   1.2       +0 -11     ports/chinese/tin/files/patch-tin_defaults (dead)
> >
> > This renaming of the patch file just because someone thought that dot
> > looks better than underscore is gratuitous and should not have been
> > done.  (Not to mention that things that this patch tries to accomplish
> > are usually done with one simple REINPLACE_CMD line.)
> 
> I suspect the motivation for the change was to canonicalize the filename
> as described in the PH.

I understand the motivation; for newly created files, PH rules obviously
should be followed.  For already existing patches, esp. when their contents
stays the same, such blunt renames only cause unnecessary stress on the repo
and taint the history.  Ergo, should be avoided.

./danfe