cvs commit: ports/editors/nedit/files patch-util-misc.c

[Doug Barton]

On 02/03/2012 08:35, Alexey Dokuchaev wrote:
> I concur.  While it's very tempting to fix FreeBSD port (especially when
> it's maintained by you (not you == Daniel, but in general sense)) we should
> always first contact upstream maintainers/vendor and submit a fix and (at
> best) ask for review. 

Right, with the qualification you gave below. I'd also add an exception
for "Obviously correct change" since I like to think that we can give
our maintainers credit for a clue or 2. :)

> In case upstream maintainers are not very responsive,
> but fix is critical or trivial enough, it's OK to fix such port directly,
> but upstream bug tracker should be filled with detailed bug description and
> attached patch.

I'd also add that mentioning "I did/did not submit this upstream
because..." and if appropriate, "... and I was told that ..." to the
commit log would be a good thing. Not only for those of us who review
these things as they go by, but also for posterity in case things don't
go as planned.

-- 

	It's always a long day; 86400 doesn't fit into a short.

	Breadth of IT experience, and depth of knowledge in the DNS.
	Yours for the right price.  :)  http://SupersetSolutions.com/