cvs commit: ports/finance/quantlib Makefile distinfo pkg-plist

Gerald Pfeifer gerald at pfeifer.com
Sun Sep 4 04:21:58 UTC 2011


On Mon, 30 May 2011, b. f. wrote:
> CPPFLAGS is now added to MAKE_ENV in bsd.port.mk, so it is unnecessary
> to add it here, in the port Makefile.  I'm not sure why portlint warns
> about this addition in the case of CONFIGURE_ENV, but not MAKE_ENV.
> The original request for this warning,
> 
> http://www.FreeBSD.org/cgi/query-pr.cgi?pr=155550
> 
> , asked for checks in both cases.

Philippe, I see you did not make the change Brendan asked for; may
I apply the patch below?

Brendan, as for your observation, I just filed PR/160448.

Gerald

Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/finance/quantlib/Makefile,v
retrieving revision 1.32
diff -u -r1.32 Makefile
--- Makefile	30 May 2011 11:36:24 -0000	1.32
+++ Makefile	4 Sep 2011 03:49:52 -0000
@@ -23,7 +23,7 @@
 GNU_CONFIGURE=	yes
 CPPFLAGS=	${PTHREAD_CFLAGS} -I${LOCALBASE}/include
 LDFLAGS=	${PTHREAD_LIBS} -L${LOCALBASE}/lib
-MAKE_ENV=	CPPFLAGS="${CPPFLAGS}" LDFLAGS="${LDFLAGS}"
+MAKE_ENV=	LDFLAGS="${LDFLAGS}"
 USE_LDCONFIG=	yes
 
 MAN1=		quantlib-config.1 quantlib-test-suite.1


More information about the cvs-ports mailing list