cvs commit: ports/net/minidlna Makefile distinfo pkg-descr ports/net/minidlna/files BSDmakefile patch-2928850 patch-aa patch-conf patch-minidlna.c patch-upnphttp

[Adrian Murphy]

Hi Mikhail,

I found this update to minidlna broke my installation.

On 21/09/2011 14:36, Mikhail Teterin wrote:
> mi          2011-09-21 05:06:13 UTC
>
>    FreeBSD ports repository
>
>    Modified files:
>      net/minidlna         Makefile distinfo pkg-descr
>      net/minidlna/files   BSDmakefile patch-aa patch-minidlna.c
>                           patch-upnphttp
>    Added files:
>      net/minidlna/files   patch-conf
>    Removed files:
>      net/minidlna/files   patch-2928850
>    Log:
>    Upgrade to the latest version from author: 1.0.22
>
>    Revision  Changes    Path
>    1.4       +5 -6      ports/net/minidlna/Makefile
>    1.2       +2 -2      ports/net/minidlna/distinfo
>    1.3       +1 -1      ports/net/minidlna/files/BSDmakefile
>    1.2       +0 -639    ports/net/minidlna/files/patch-2928850 (dead)
>    1.2       +254 -0    ports/net/minidlna/files/patch-aa
>    1.1       +13 -0     ports/net/minidlna/files/patch-conf (new)
>    1.2       +31 -13    ports/net/minidlna/files/patch-minidlna.c
>    1.2       +0 -35     ports/net/minidlna/files/patch-upnphttp
>    1.2       +0 -3      ports/net/minidlna/pkg-descr


My PC is running FreeBSD 8.2-RELEASE #0: Thu Feb 17 02:41:51 UTC 2011
root at mason.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  amd64

I found that it works normally connecting with my Sony Bravia TV and 
PS3, but as soon as an iPad2 running iOS 4.3.5 connects with minidlna it 
would crash. I believe Windows media player cause the same grief.
On another i386 PC I tried, I don't experience this problem.

With gdb I found the problem was in read_random_bytes in the file uuid.c

The port provides the patch file, patch-aa, which defines "long r;" in 
read_random_bytes, which is 8 bytes on my AMD64 PC.  On i386, long takes 
4 bytes. I changed the patch file so that "long r" becomes "int r" and 
this fixes the crash problem.

I'm not convinced long -> int is the right way to fix this. What do you 
think?

Thanks for your, and others, work on minidlna. It's awesome for 
connecting my telly, laptop and iPad to the photos, music and videos on 
my computer.

Regards, Adrian