cvs commit: ports/graphics/freeimage Makefile distinfo pkg-descr ports/graphics/freeimage/files patch-Source-LibOpenJPEG_opj_malloc.h

[Pietro Cerutti]

On 2010-Dec-30, 16:18, Stanislav Sedov wrote:
> On Mon, 20 Dec 2010 12:07:27 +0100
> "Pietro Cerutti" <gahr at gahr.ch> mentioned:
> 
> > 
> > 1) I don't think anybody is interested in this pkg-descr change: you
> >    have done a minor rephrasing but haven't minimally changed the sense.
> 
> I don't want to start a flame war, but why did you committed it then?
> Everything changed deserves at least a small note in the commit log.

Well I tend to disagree here. I see a commit message as a way to convey
important notes about a commit. The files touched by a commit are listed,
and the repository is there for anybody to see, if one is interested in
the details. Let's not bury an important key note beneath a mountain of details.

I would like to avoid to have to write a line like this

- add a patch file to fix an include line that used the deprecated
  header alloc.h instead of stdlib.h

for a patch file like this

- #include <alloc.h>
+ #include <stdlib.h>


Let's please keep things slim and functional :)

-- 
Pietro Cerutti
The FreeBSD Project
gahr at FreeBSD.org

PGP Public Key:
http://gahr.ch/pgp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-ports/attachments/20110104/0a335634/attachment.pgp