cvs commit: ports/net-p2p/amule Makefile ports/net-p2p/amule/files patch-configure

[Chris Rees]

2011/12/27 Alexey Dokuchaev <danfe at freebsd.org>:
> On Tue, Dec 27, 2011 at 08:58:35AM +0000, Chris Rees wrote:
>> 2011/12/27 Alex Dupre <ale at freebsd.org>:
>> > Alexey Dokuchaev ha scritto:
>> >> Right, so perhaps this line should be dropped completely, not just
>> >> commented out.  On a related note, thanks for removing LICENSE_FILE
>> >> knobs for known standard licenses, we need to cure this abuse for
>> >> quite a while.
>> >
>> > Well, actually the license framework documentation says exactly the
>> > opposite, it recommends to set LICENSE_FILE also for known licenses.
>
> Which is very stupid.  One of the reasons to use license framework is to
> avoid spamming the filesystem with umpteen identical copies of GPL et al.
> Unless the port installs some proprietary license file, setting LICENSE_FILE
> should not use needed or used.
>
>> Oh dear.... reading bsd.licenses.mk shows that there's no 'pool' of
>> known licenses, which means that doing stuff like LICENSE=GPLv2
>> without LICENSE_FILE violates the GPL.
>>
>> I'll look at making a 'pool', now where to store it...
>
> Yes, ideally, we have to store all common licenses texts in out place, and
> create symlinks over there for each individual port (i.e. under
> $localbase/share/licenses/<portname>).

I smell a bikeshed starting...

but to avoid failures every time a new licence is added, it'll need to
be under ports/ somewhere...

Chris