cvs commit: ports/devel/thrift Makefile distinfo pkg-plist
ports/devel/thrift/files patch-configure.ac
patch-lib__c_glib__src__transport__thrift_framed_transport.h
patch-lib__c_glib__src__transport__thrift_socket.h
patch-lib__cpp__src__server__TNonblockingServer.h
Sergey Skvortsov
skv at FreeBSD.org
Sat Dec 24 18:35:04 UTC 2011
On 08.12.2011 15:02, Michael Scheidell wrote:
> scheidell 2011-12-08 11:02:04 UTC
>
> FreeBSD ports repository
>
> Modified files:
> devel/thrift Makefile distinfo pkg-plist
> Added files:
> devel/thrift/files
> patch-lib__c_glib__src__transport__thrift_framed_transport.h
> patch-lib__c_glib__src__transport__thrift_socket.h
> patch-lib__cpp__src__server__TNonblockingServer.h
> Removed files:
> devel/thrift/files patch-configure.ac
> Log:
> -Update to 0.7.0 [1]
> -Fix Build C++ Library [1]
> -pet portlint
>
> PR: ports/159902 [1]
> Submitted by: Valery Komarov <komarov at valerka.net> [1]
> Approved by: skv (maintainer timeout, 100 days), gabor (mentor)
> Feature safe: yes
Hi.
1. Before committing, please check that included in PR software version
is fresh enough:
- 0.8.0 was released on 2011-11-30:
http://archive.apache.org/dist/thrift/0.8.0/
- your commit was on 2011-12-08.
2. Thrift port is critical enough because many other ports depend on it:
find /usr/ports/ -name Makefile -exec grep -w -l thrift {} \+
So you must (not "should") test all depended ports in Tinderbox before
committing somewhat in "devel/thrift".
You obviously did not test even "devel/*-[Tt]hrift*" ports.
3. Please run "portlint -C" before commit.
Right now we can see fatal error:
FATAL: /usr/home/godegisel/ports/devel/thrift/pkg-plist: [95]:
installing pkg-config files into lib/pkgconfig. All pkg-config files
must be installed into libdata/pkgconfig for them to be found by pkg-config.
4. Because you took maintainership on "devel/thrift" from me, please
also take "devel/ruby-thrift" and "devel/p5-Thrift".
Thanks in advance.
--
Sergey Skvortsov
mailto: skv at FreeBSD.org
More information about the cvs-ports
mailing list