cvs commit: ports/net-mgmt/mrtg/files mrtg_daemon.in

[Doug Barton]

A few suggestions for the rc.d file:

1. The options that you have _knobs for (such as _group, etc.) should
be in command_args, not in the default _flags option. I.e., there is no
reason to make them options twice.

2. The 2 separate lines:
: ${mrtg_daemon_pidfile="/var/run/mrtg/mrtg.pid"}
pidfile=${mrtg_daemon_pidfile}

Can be collapsed into one:
pidfile=${mrtg_daemon_pidfile="/var/run/mrtg/mrtg.pid"}

3. If mrtg_daemon_config is mandatory, it should be added to
required_files.

See
http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html
for more information.


Doug


On 12/03/2011 15:06, Michael Scheidell wrote:
> scheidell    2011-12-03 23:06:47 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     net-mgmt/mrtg/files  mrtg_daemon.in 
>   Log:
>   - Add shutdown keyword to rc script
>   
>   PR:             ports/162963  http://www.FreeBSD.org/cgi/query-pr.cgi?pr=162963
>   Submitted by:   maintainer
>   Approved by:    maintainer,gabor(mentor)
>   Feature safe:   yes
>   
>   Revision  Changes    Path
>   1.3       +2 -1      ports/net-mgmt/mrtg/files/mrtg_daemon.in
> 
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/mrtg/files/mrtg_daemon.in.diff?&r1=1.2&r2=1.3&f=h
> 



-- 

		[^L]

	Breadth of IT experience, and depth of knowledge in the DNS.
	Yours for the right price.  :)  http://SupersetSolutions.com/