cvs commit: ports/sysutils/boxbackup Makefile distinfo
pkg-deinstall
pkg-descr pkg-install pkg-plist ports/sysutils/boxbackup/files
999.boxbackup.in
bbackupd.in bbackupd.sh.in bbstored.in bbstored.sh.in patch-configure.ac
...
Doug Barton
dougb at FreeBSD.org
Wed Aug 31 01:45:43 UTC 2011
These rc.d scripts are in very poor shape, and should not have been
committed as they were. Please review
http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html.
Also the COMMENT was not in the proper format, and UNIX is a typo.
The biggest single problem with the rc.d scripts was failure to set
pidfile= explicitly. The _pidfile convention is meaningless to rc.subr
(and frankly, an almost-always-overkill tradition that should probably
be killed instead of perpetuated). The other problems are in style,
formatting, etc.
hth,
Doug
On 08/25/2011 09:03, Ryan Steinmetz wrote:
> zi 2011-08-25 16:03:50 UTC
>
> FreeBSD ports repository
>
> Modified files:
> sysutils/boxbackup Makefile distinfo pkg-descr pkg-plist
> sysutils/boxbackup/files pkg-message.client pkg-message.server
> Added files:
> sysutils/boxbackup/files 999.boxbackup.in bbackupd.in
> bbstored.in
> Removed files:
> sysutils/boxbackup pkg-deinstall pkg-install
> sysutils/boxbackup/files bbackupd.sh.in bbstored.sh.in
> patch-configure.ac
> patch-lib-common-BoxPortsAndFiles.h
> Log:
> Update to 0.11.1
> Pacify portlint(1)
> Use USERS/GROUPS
>
> PR: ports/159399 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=159399
> Submitted by: James O'Gorman <james at netinertia.co.uk> (maintainer)
> Approved by: wxs (mentor)
>
> Revision Changes Path
> 1.18 +44 -49 ports/sysutils/boxbackup/Makefile
> 1.5 +2 -2 ports/sysutils/boxbackup/distinfo
> 1.1 +66 -0 ports/sysutils/boxbackup/files/999.boxbackup.in (new)
> 1.1 +27 -0 ports/sysutils/boxbackup/files/bbackupd.in (new)
> 1.4 +0 -27 ports/sysutils/boxbackup/files/bbackupd.sh.in (dead)
> 1.1 +27 -0 ports/sysutils/boxbackup/files/bbstored.in (new)
> 1.4 +0 -27 ports/sysutils/boxbackup/files/bbstored.sh.in (dead)
> 1.2 +0 -35 ports/sysutils/boxbackup/files/patch-configure.ac (dead)
> 1.3 +0 -25 ports/sysutils/boxbackup/files/patch-lib-common-BoxPortsAndFiles.h (dead)
> 1.2 +2 -2 ports/sysutils/boxbackup/files/pkg-message.client
> 1.2 +2 -2 ports/sysutils/boxbackup/files/pkg-message.server
> 1.2 +0 -69 ports/sysutils/boxbackup/pkg-deinstall (dead)
> 1.2 +1 -1 ports/sysutils/boxbackup/pkg-descr
> 1.4 +0 -36 ports/sysutils/boxbackup/pkg-install (dead)
> 1.4 +12 -9 ports/sysutils/boxbackup/pkg-plist
>
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/sysutils/boxbackup/Makefile.diff?&r1=1.17&r2=1.18&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/sysutils/boxbackup/distinfo.diff?&r1=1.4&r2=1.5&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/sysutils/boxbackup/files/999.boxbackup.in
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/sysutils/boxbackup/files/bbackupd.in
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/sysutils/boxbackup/files/bbackupd.sh.in
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/sysutils/boxbackup/files/bbstored.in
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/sysutils/boxbackup/files/bbstored.sh.in
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/sysutils/boxbackup/files/patch-configure.ac
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/sysutils/boxbackup/files/patch-lib-common-BoxPortsAndFiles.h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/sysutils/boxbackup/files/pkg-message.client.diff?&r1=1.1&r2=1.2&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/sysutils/boxbackup/files/pkg-message.server.diff?&r1=1.1&r2=1.2&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/sysutils/boxbackup/pkg-deinstall
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/sysutils/boxbackup/pkg-descr.diff?&r1=1.1&r2=1.2&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/sysutils/boxbackup/pkg-install
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/sysutils/boxbackup/pkg-plist.diff?&r1=1.3&r2=1.4&f=h
>
--
Nothin' ever doesn't change, but nothin' changes much.
-- OK Go
Breadth of IT experience, and depth of knowledge in the DNS.
Yours for the right price. :) http://SupersetSolutions.com/
-------------- next part --------------
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/sysutils/boxbackup/Makefile,v
retrieving revision 1.18
diff -u -r1.18 Makefile
--- Makefile 25 Aug 2011 16:03:49 -0000 1.18
+++ Makefile 31 Aug 2011 01:39:31 -0000
@@ -7,13 +7,14 @@
PORTNAME= boxbackup
PORTVERSION= 0.11.1
+PORTREVISION= 1
CATEGORIES= sysutils
MASTER_SITES= SF
PKGNAMESUFFIX= ${CLIENT_OR_SERVER}
EXTRACT_SUFX= .tgz
MAINTAINER= james at netinertia.co.uk
-COMMENT= An open source, completely automatic on-line backup system for UNIX
+COMMENT= Open source, completely automatic on-line backup system for Unix
LICENSE= BSD GPLv2
LICENSE_COMB= dual
Index: files/bbackupd.in
===================================================================
RCS file: /home/pcvs/ports/sysutils/boxbackup/files/bbackupd.in,v
retrieving revision 1.1
diff -u -r1.1 bbackupd.in
--- files/bbackupd.in 25 Aug 2011 16:03:49 -0000 1.1
+++ files/bbackupd.in 31 Aug 2011 01:39:31 -0000
@@ -1,27 +1,28 @@
#!/bin/sh
-#
+
# $FreeBSD: ports/sysutils/boxbackup/files/bbackupd.in,v 1.1 2011/08/25 16:03:49 zi Exp $
#
# PROVIDE: bbackupd
# REQUIRE: NETWORKING
# KEYWORD: shutdown
-
#
# Add the following line to /etc/rc.conf to enable bbackupd:
#
-#bbackupd_enable="YES"
-#
-
-: ${bbackupd_enable:="NO"}
-: ${bbackupd_flags:="%%PREFIX%%/etc/box/bbackupd.conf"}
-: ${bbackupd_pidfile:="/var/run/bbackupd.pid"}
+# bbackupd_enable="YES"
. /etc/rc.subr
name="bbackupd"
rcvar=`set_rcvar`
+
+load_rc_config $name
+
+: ${bbackupd_enable:="NO"}
+: ${bbackupd_flags:="%%PREFIX%%/etc/box/bbackupd.conf"}
+
+pidfile=${bbackupd_pidfile:-"/var/run/bbackupd.pid"}
+
command="%%PREFIX%%/bin/bbackupd"
extra_commands="reload"
-load_rc_config $name
run_rc_command "$1"
Index: files/bbstored.in
===================================================================
RCS file: /home/pcvs/ports/sysutils/boxbackup/files/bbstored.in,v
retrieving revision 1.1
diff -u -r1.1 bbstored.in
--- files/bbstored.in 25 Aug 2011 16:03:49 -0000 1.1
+++ files/bbstored.in 31 Aug 2011 01:39:31 -0000
@@ -1,27 +1,28 @@
#!/bin/sh
-#
+
# $FreeBSD: ports/sysutils/boxbackup/files/bbstored.in,v 1.1 2011/08/25 16:03:49 zi Exp $
#
# PROVIDE: bbstored
# REQUIRE: NETWORKING
# KEYWORD: shutdown
-
#
# Add the following line to /etc/rc.conf to enable bbstored:
#
-#bbstored_enable="YES"
-#
-
-: ${bbstored_enable:="NO"}
-: ${bbstored_flags:="%%PREFIX%%/etc/box/bbstored.conf"}
-: ${bbstored_pidfile:="/var/run/bbstored.pid"}
+# bbstored_enable="YES"
. /etc/rc.subr
name="bbstored"
rcvar=`set_rcvar`
+
+load_rc_config $name
+
+: ${bbstored_enable:="NO"}
+: ${bbstored_flags:="%%PREFIX%%/etc/box/bbstored.conf"}
+
+pidfile=${bbstored_pidfile:-"/var/run/bbstored.pid"}
+
command="%%PREFIX%%/bin/bbstored"
extra_commands="reload"
-load_rc_config $name
run_rc_command "$1"
More information about the cvs-ports
mailing list