cvs commit: ports/www/weave Makefile

Grzegorz Blach magik at roorback.net
Fri May 21 06:28:26 UTC 2010


On Thu, 20 May 2010 17:00:19 -0700 (PDT), QAT at FreeBSD.org wrote:
> The Restless Daemon identified a coredump error while trying to build:
>  weave-1.2.3,2 maintained by magik at roorback.net
>  Makefile ident: $FreeBSD: ports/www/weave/Makefile,v 1.16 2010/05/20
>  21:24:47 pav Exp $
> 
> Excerpt from http://QAT.TecNik93.com/logs/8-STABLE-NPD/weave-1.2.3,2.log
:


I don't try to build current version of weave,
but this log looks like, building was broken by recent patch for weave.

@@ -59,7 +59,7 @@ PLIST_SUB+=	XPI_XPIDIR="${XPI_DIR:S,^${P
 
 post-patch:
 	@${REINPLACE_CMD} -e "s|\$$(shell hg tip --template
'{node\|short}')|${REVID}|g" ${WRKSRC}/Makefile
-.if ${PLATFORM} == FreeBSD_x86_64-gcc3
+.if ${ARCH} == amd64
 	${REINPLACE_CMD} -e 's|arch = amd64|arch = x86_64|g'
${WRKSRC}/crypto-obsolete/src/Makefile
 .endif


Reinplace that change arch = amd64 to arch = x86_64, should be applied
only when ${WITH_FF35} is set.
I used .if ${PLATFORM} == FreeBSD_x86_64-gcc3, because this is equal only
for ${WITH_FF35} == true && ${ARCH} == amd64,
But using .if ${WITH_FF35} == true (without ${ARCH} comparison) will work
too,
beacause this patch don't change anything on i386 platform, for both
version of Firefox.


So pav, in the future please send me a patches for review.



More information about the cvs-ports mailing list