cvs commit: ports/dns/dnsmasq Makefile ports/japanese/FreeWnn-server Makefile ports/mail/mailscanner Makefile ports/mail/mailscanner/files mta.in ports/mail/mailscanner-devel Makefile ports/mail/mailscanner-devel/files mta.in ...

[Doug Barton]

On 03/30/10 00:04, Matthew D. Fuller wrote:
> On Sun, Mar 28, 2010 at 05:52:12AM +0000 I heard the voice of
> Doug Barton, and lo! it spake thus:
>>
>>   1.37      +0 -1      ports/mail/spamass-milter/Makefile
> 
> This broke spamass-milter.
> 
> -RC_SCRIPTS_SUB=        PREFIX=${PREFIX} RC_SUBR=${RC_SUBR}
> 
> This var is still called for in post-patch:
> 
>     @${SED} ${RC_SCRIPTS_SUB:S/$/!g/:S/^/ -e s!%%/:S/=/%%!/} \
>         ${FILESDIR}/spamass-milter.in > ${WRKDIR}/spamass-milter

Thanks for pointing this out, and my apologies to all affected
(especially pgolluci). After testing the fix I just committed it to
avoid continued breakage.

I was fooled by the fact that the port is already using USE_RC_SUBR
properly, but I failed to search for additional examples of
RC_SCRIPTS_SUB elsewhere. That's my second rc_subr flavored pointy hat
for the collection ...


Doug

-- 

	... and that's just a little bit of history repeating.
			-- Propellerheads

	Improve the effectiveness of your Internet presence with
	a domain name makeover!    http://SupersetSolutions.com/