cvs commit: ports/java/jdk16 Makefile

Wed Jun 9 06:31:10 UTC 2010

On Tue, 8 Jun 2010 20:51:49 -0700
Greg Lewis <glewis at eyesbeyond.com> wrote:

> On Wed, Jun 09, 2010 at 12:47:57AM +0300, Ion-Mihai Tetcu wrote:
> > On Tue, 8 Jun 2010 17:28:08 -0400
> > "Philip M. Gollucci" <pgollucci at p6m7g8.com> wrote:
> > > On 6/8/2010 4:34 PM, Rob Farmer wrote:
> > > > On Tue, Jun 8, 2010 at 1:17 PM, Ion-Mihai Tetcu
> > > > <itetcu at freebsd.org> wrote:
> > > >> itetcu      2010-06-08 20:17:37 UTC
> > > >>
> > > >>  FreeBSD ports repository
> > > >>
> > > >>  Modified files:
> > > >>    java/jdk16           Makefile
> > > >>  Log:
> > > >>  Mark BROKEN, I'm tired to see QAT loosing time trying to
> > > >> build it.
> > > > 
> > > > Could you move this inside an .if defined(PACKAGE_BUILDING) or
> > > > something? It seems a little extreme (a lot of stuff has a jdk
> > > > dependency)
> > 
> > I know, believe me:
> >  > ./QAT_getFailledDepends.sh -d java/jdk16
> > +--------------------------------------------+
> > | No. of failed ports becasue of java/jdk16: |
> > +--------------------------------------------+
> > |                                        145 |
> > +--------------------------------------------+
> > 
> > > and I just built this yesterday on amd64 current with no issues.
> > > > 
> > > Yeah I've built it too and recently (as much as I despise java)
> > > http://people.freebsd.org/~pgollucci/FreeBSD/logs/9-CURRENT-amd64-rubygems18/jdk-1.6.0.3p4_15.log
> > > 
> > > nothing against glewis, he's doing great work.
> > 
> > It's been failing each time on QAT since 15.02, and for others since
> > January. I don't see what it has to do with package building.
> > 
> > I guess it would nor err like this after: 
> >  r200039/_FreeBSD_version 900003 for HEAD  and  r203299/800502
> > (QAT's base OS is a 8.0-RELEASE-p2)
> > 
> > However it's failing for me on an other 8-STABLE tinderbox also,
> > which has a much newer base OS  kernel, but in a different way.
> > 
> > I will invetigate more tomorrow, time permitting.
> 
> Please revert your commit.  Its building fine for myself and many
> other users.

Done.

> I cannot reproduce the QAT failure and there are no PRs about it.

From the point of view of something being reported as being broken,
please consider QATMail as having at least the same relevance as a PR.

> QAT complains thusly:
> 
> ../../../../src/solaris/hpi/native_threads/src/interrupt_md.c:115:
> error: static declaration of 'sigignore' follows non-static
> declaration /usr/include/signal.h:103: error: previous declaration of
> 'sigignore' was here
> 
> The build uses the following logic to detect the presence of
> sigignore:
> 
> ifeq ($(OS_VENDOR),FreeBSD)
> OS_RELDATE := $(shell sysctl kern.osreldate | cut -d' ' -f2)
> HAS_SIGIGNORE := $(shell if [ $(OS_RELDATE) -ge 800502 -a
> $(OS_RELDATE) -lt 900000 -o $(OS_RELDATE) -ge 900003 ]; then echo
> "1"; fi) ifeq ($(HAS_SIGIGNORE),1) override HAVE_SIGIGNORE          =
> true endif
> endif
> 
> I suspect that works for 99.9% of users but may fail for jailed 
> applications like QAT where syctl outputs a kern.osreldate that
> doesn't match the userland headers.  I'm open to suggestions on
> different logic, but I don't feel the narrow failure mode justifies
> your change. 

Philip's suggestion looks right to me.

> If you don't want QAT to build the port then modify QAT to be able to
> exclude ports rather than hurting the vast majority of users for whom
> this port does build.

That would be a two-liner (and would save some 6 minutes out of 10
spent on trying to build it), but no, I do want QAT and Pointy to be
able to buid it :)

> FWIW the port builds without problem on my 8.0-RELEASE-p2 amd64 box.

Well, while here, I also have trouble building it on an other
tinderbox, with the host OS (world and kernel) is May  2 20:17:59 EEST
2010, and the jails src from:

System	FreeBSD 8 (RELENG_8)	2010-01-10 21:57:10
http://t64.tecnik93.com//errors/8-STABLE-amd64/jdk-1.6.0.3p4_15.log

System	FreeBSD 7 (RELENG_7)	2009-12-13 03:47:54
http://t64.tecnik93.com//errors/7-STABLE-amd64/jdk-1.6.0.3p4_15.log

>>>Recursively making javac all @ Sun Jun  6 09:05:07 UTC 2010 ...
gmake[5]: Entering directory `/work/a/ports/java/jdk16/work/j2se/make/sun/javac/javac'
/work/a/ports/java/jdk16/work/control/build/bsd-amd64/bin/java  -Xmx512m -Xms256m -classpath ../../../../make/tools/CompileProperties CompileProperties ../../../../src/share/classes/com/sun/tools/javac/resources/compiler.properties /work/a/ports/java/jdk16/work/control/build/bsd-amd64/gensrc/com/sun/tools/javac/resources/compiler.java 
There was an error trying to initialize the HPI library.
Could not create the Java virtual machine.
gmake[5]: *** [/work/a/ports/java/jdk16/work/control/build/bsd-amd64/gensrc/com/sun/tools/javac/resources/compiler.java] Error 1

-- 
IOnut - Un^d^dregistered ;) FreeBSD "user"
  "Intellectual Property" is   nowhere near as valuable   as "Intellect"
FreeBSD committer -> itetcu at FreeBSD.org, PGP Key ID 057E9F8B493A297B
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-ports/attachments/20100609/69cac519/signature.pgp