cvs commit: ports/ftp/proftpd Makefile ports/ftp/proftpd/files proftpd.in proftpd.sh.in

Doug Barton dougb at FreeBSD.org
Mon Jan 4 20:46:17 UTC 2010


This is an interesting idea, one I may just steal for rc.d/named. :)

Couple of things ... first the new line has /usr/local hard-coded, it
should be %%PREFIX%%. Second, is it ever possible that proftpd will
start up without the PidFile line in the conf? If so, then there
should probably be a default setting, error checking on the pidfile
value, or both.

Also the usual note about REQUIRE: DAEMON + BEFORE: LOGIN should
probably be replaced with REQUIRE: LOGIN unless there is a good reason
to start it earlier.


hth,

Doug


Philip M. Gollucci wrote:
> pgollucci    2010-01-04 04:34:07 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     ftp/proftpd          Makefile 
>   Added files:
>     ftp/proftpd/files    proftpd.in 
>   Removed files:
>     ftp/proftpd/files    proftpd.sh.in 
>   Log:
>   - Pull the pidfile path from a central location (the config file)
>     instead of hard coding it again in the rc.d script
>   
>   PR:             ports/141945  http://www.FreeBSD.org/cgi/query-pr.cgi?pr=141945
>   Submitted by:   Danil <desruptorrogue at gmail.com>
>   
>   Revision  Changes    Path
>   1.166     +2 -1      ports/ftp/proftpd/Makefile
>   1.1       +43 -0     ports/ftp/proftpd/files/proftpd.in (new)
>   1.5       +0 -43     ports/ftp/proftpd/files/proftpd.sh.in (dead)
> 
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/ftp/proftpd/Makefile.diff?&r1=1.165&r2=1.166&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/ftp/proftpd/files/proftpd.in
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/ftp/proftpd/files/proftpd.sh.in
> 


-- 

	Improve the effectiveness of your Internet presence with
	a domain name makeover!    http://SupersetSolutions.com/

	Computers are useless. They can only give you answers.
			-- Pablo Picasso



More information about the cvs-ports mailing list