cvs commit: ports/audio Makefile ports/audio/deadbeef Makefile distinfo pkg-descr pkg-plist ports/audio/deadbeef/files patch-Makefile.am patch-Makefile.in patch-configure patch-configure.ac

[Dmitry Marakasov]

* Alexey Dokuchaev (danfe at FreeBSD.org) wrote:

> Fully qualified person id (full name) should be used when available
> (Whom: line of Makefile header).

> COMMENT=	DeaDBeeF is an audio player for GNU/Linux systems with X11
> 		^^^^^^^^^^^^
> Mentioning program name in COMMENT is redundant; simple "An audio
> player..." would be enough.  "GNU/Linux" also looks strange on BSD system.
> "Unix[-like]" would be more appropriate.

Thanks, will resolve both with the next update.

> >   1.1       +13 -0     ports/audio/deadbeef/files/patch-Makefile.am (new)
> >   1.1       +21 -0     ports/audio/deadbeef/files/patch-Makefile.in (new)
> 
> Weird.  Can you explain why both of these patches are required, since .in
> is normally generated from .am (that is, patching .in is enough unless
> the port needs more of autotools magic than simple "./configure")?

Configure tends to rerun autotools when available sometimes, thus files
gets regenerated, so to be on a safe side, sources are patched as well.
Anyway, these patches will go away with the next update.

-- 
Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
amdmi3 at amdmi3.ru  ..:  jabber: amdmi3 at jabber.ru    http://www.amdmi3.ru