cvs commit: ports GIDs UIDs ports/net Makefile ports/net/minidlna Makefile distinfo pkg-descr pkg-plist ports/net/minidlna/files BSDmakefile config.h getifaddr.c minidlna.sh.in patch-2928850 patch-aa patch-ab patch-inline patch-minidlna.c patch-upnphttp ...

[Alexey Dokuchaev]

On Tue, Dec 14, 2010 at 03:09:14AM -0500, Mikhail T. wrote:
> On 14.12.2010 02:27, Alexey Dokuchaev wrote:
> Why is dougb@ to be burdened reviewing these particular things?

Because Doug know this shit, and wants others' scripts to be nice and
dainty.  Judging by your commit, you know less then him.  I also know
less.  That's why I ask him to review every rc script I intend to commit.

> Having done the actual heavy-lifting of porting this Linux-only piece of 
> software back in June, I published the port's shar and asked -- on 
> ports@ -- for somebody else to contribute the start-up script. For 6 
> months no one has and now, finally, got around to learning, how to do 
> this myself.

Sorry that you've received no help on ports at .  But I have an advice:
read cvs-ports@ instead.  Then you'll see that dougb@ had been patiently
and calmly reviewing huge number of rc scripts, telling how can they be
improved.  Personally, I find cvs-ports@ a lot more valuable than ports at .

> >>   1.1       +11 -0     ports/net/minidlna/files/patch-aa (new)
> >>   1.1       +9 -0      ports/net/minidlna/files/patch-ab (new)
> >Apart from number of style bugs in the Makefile, can you explain why did
> Portlint's only complaint is the single MASTER_SITE... Feel free to 
> submit patches.

I will.  In the mean time, fuck portlint(1).  Think for yourself.

> >you go with `patch-xy' files, which is against current naming policy?
> Because I felt like this color was matching this bike shed the best... 
> Because several naming styles exist currently and this particular one 
> reminds the audience of the good old times, [...]

Please reread the PH.  You are clearly very wrong here.

./danfe