cvs commit: ports/www/varnish Makefile ports/www/varnish/files
pkg-message.in varnishd.in varnishlog.in varnishncsa.in
des at des.no
Wed Oct 14 09:09:23 UTC 2009
Doug Barton <dougb at FreeBSD.org> writes:
> Dag-Erling Smørgrav <des at des.no> writes:
> > That's a lot of extra code for no perceivable benefit...
> The if/else code is essentially the same as yours. Splitting out the
> flags that are common between your two options makes the code more
> readable. There is also the issue that code in rc.d scripts shouldn't
> run unconditionally, but I don't regard that as critical in this case
> since you're just setting variables.
> Ultimately it's up to you whether you want to accept the patches or
> not. I think they're useful but I am not going to make a stink about it.
The *rest* of the patch is very useful. Thank you :)
Dag-Erling Smørgrav - des at des.no
More information about the cvs-ports