cvs commit: ports/x11-toolkits/linux-f8-openmotif Makefile pkg-plist

[Ion-Mihai Tetcu]

On Wed, 13 May 2009 09:12:27 +0400
Boris Samorodov <bsam at ipt.ru> wrote:

> On Wed, 13 May 2009 00:35:31 +0300 Ion-Mihai Tetcu wrote:
> > On Tue, 12 May 2009 21:28:06 +0400
> > Boris Samorodov <bsam at ipt.ru> wrote:
> 
> > > On Tue, 12 May 2009 12:56:53 -0400 Philip M. Gollucci wrote:
> > > > Boris Samorodov wrote:
> > > 
> > > > >   No PORTREVISION bump is needed.
> > > > > | -BUILD_DEPENDS=	rpm2cpio:${PORTSDIR}/archivers/rpm
> > > > >
> > > > I thought you always had to BUMP PORTREVISION when changing
> > > > DEPENDS since you directly affect the resultant package ? Can
> > > > you enlighten me ?
> > > 
> > > Two arguments:
> > > . the package for this port is never built;
> 
> > In general, this argument is is wrong, as one can use
> > FORCE_PACKAGES to build them locally.
> 
> I was talking about oficial packages.

Let's be consistent. Just because a port is marked NO_PACKAGE it
doesn't mean IMO we shouldn't bump PORTREVISION if we'd do this if the
port wouldn't be marked NO_PACKAGE.

> As for custom packages I'm not sure if we should bump PORTREVISION
> when any custom package may be affected by a commit.

- IMO yes.
- PH is a little vague
- current practice seems to be no

> Should a PORTREVISION be bumped if non-defaults (say, OPTIONS) are
> changed?

New PKGVERSION triggers a port rebuild on the cluster and lets both
ports and packages users know something changed.

- If changing OPTIONS changes dependencies in the default config then
it's obvious you need to bump.
- If you flip the default state of an OPTION the you need to bump as the
resulting package will be different irrespective of depends/plist
changes or not.
- If you add an OPTION that defaults to on then you need to bump, if the
default package will be in any way different that it was. If it
defaults to off it's debatable.

The only ting that let the users know something changed is a new
PKGVERSION. If only because of this I'd advocate for bumping.

> > > . this dependency still (indirectly) exists since this port
> > >   depends upon linux_base-f8 which depends upon archivers/rpm.
> 
> > So the make describe output is the same?
> 
> Strictly speaking, no: archivers/rpm moved from build_depends
> to extract_depends. But that doesn't affect a package using.
> 
> Those two arguments in conjunction convinced me not to bump
> PORTREVISION.

Yes, in this case it wasn't needed.

-- 
IOnut - Un^d^dregistered ;) FreeBSD "user"
  "Intellectual Property" is   nowhere near as valuable   as "Intellect"
FreeBSD committer -> itetcu at FreeBSD.org, PGP Key ID 057E9F8B493A297B
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-ports/attachments/20090517/903f426b/signature.pgp