cvs commit: ports/security/scanlogd Makefile ports/security/scanlogd/files scanlogd.in scanlogd.sh

[Doug Barton]

Roman Bogorodskiy wrote:
> novel       2009-08-21 18:55:12 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     security/scanlogd    Makefile 
>   Added files:
>     security/scanlogd/files scanlogd.in 
>   Removed files:
>     security/scanlogd/files scanlogd.sh 
>   Log:
>   Improve USE_RC_SUBR usage.
>   
>   PR:             136849  http://www.FreeBSD.org/cgi/query-pr.cgi?pr=136849
>   Submitted by:   pgollucci
>   
>   Revision  Changes    Path
>   1.9       +3 -9      ports/security/scanlogd/Makefile
>   1.1       +25 -0     ports/security/scanlogd/files/scanlogd.in (new)
>   1.5       +0 -25     ports/security/scanlogd/files/scanlogd.sh (dead)
> 
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/security/scanlogd/Makefile.diff?&r1=1.8&r2=1.9&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/security/scanlogd/files/scanlogd.in
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/security/scanlogd/files/scanlogd.sh

Thanks for committing this improvement. :)  Couple of notes on the
rc.d script, none of them life-threatening:

1. Unless this tool provides services that are needed for logging in,
"REQUIRE: DAEMON, BEFORE: LOGIN" should be replaced with "REQUIRE:LOGIN"
2. The default variable assignment should come after load_rc_config,
and should use just - instead of :-
3. In my last cleanup pass I missed the empty "required_files"
variable. That should be removed (or filled in, as appropriate).

As always, more info in
http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html

hth,

Doug

-- 

    This .signature sanitized for your protection