cvs commit: ports/games/alienarena Makefile distinfo pkg-descr pkg-message ports/games/alienarena/files alienarena-ded.in alienarena-sdl.in alienarena.in patch-Makefile patch-client__menu.c patch-game__acesrc__acebot.h patch-game__acesrc__acebot_nodes.c ...

[Doug Barton]

Alexey Dokuchaev wrote:
> On Mon, Mar 24, 2008 at 08:42:28PM +0000, Alejandro Pulver wrote:
>>   Only for games/alienarena:
>>   - Remove local patches (now integrated upstream).
>>   - Check for WITH_* instead of !WITHOUT_* (avoid double negation).
> 
> I've been under impression that common practice is to check for WITH_FOO
> with knobs that are default to off, and !WITHOUT_FOO that default to on.

Ignore previous conventions AND common practice. :) Since OPTIONS are 
now fixed, you can make this work in any of the 4 possible combinations:

1. Always enable unless explicitly disabled
2. Enable only if explicitly enabled
3. Disable only if explicitly disabled
4. Always disable unless explicitly enabled

Hopefully I can leave the corresponding .if() statements as an exercise 
for the readers? :)

Personally I always use either 1 or 4, but I can imagine situations 
where 2 or 3 might be desirable. However if we're going to argue what 
the _default_ usage should be, I would argue that 1 and 4 (i.e., doing 
it the old way) should be the default since it doesn't leave any 
ambiguity at package creation time, but still lets the user have 
flexibility when compiling it locally.

Doug

-- 

     This .signature sanitized for your protection