cvs commit: ports/net/tn5250j Makefile

[Marcin Cieslak]

Jeremy Messenger wrote:
> On Fri, 13 Jun 2008 21:20:44 -0500, Marcin Cieslak <saper at system.pl> wrote:
> 
>> Jeremy Messenger wrote:
>>> Do that need to be check careful. I rather to avoid use ${BUILD_DEPENDS}
>>> and do the copy-n-paste full lines instead. Are zip and ant need to be
>>> in the runtime dependency? The ${BUILD_DEPENDS} causes USE_*=yes to be
>>> include in the runtime dependency.
>>
>> No, zip is needed only to unpack the distfile, ant is only needed to
>> build the stuff (it's just like "make").
> 
> # make run-depends-list | grep ant
> /usr/ports/devel/apache-ant
> 

That's exactly the reason why RUN_DEPENDS= ${BUILD_DEPENDS} is wrong :-(
Thanks for pointing out.

There I would propose another patch:

retrieving revision 1.1
diff -u -u -r1.1 Makefile
--- Makefile	13 Jun 2008 02:37:00 -0000	1.1
+++ Makefile	14 Jun 2008 12:31:54 -0000
@@ -17,8 +17,13 @@

  BUILD_DEPENDS=	${JAVAJARDIR}/mail.jar:${PORTSDIR}/java/javamail \
  		${JYTHON_JAR}:${PORTSDIR}/lang/jython \
-		${JAVAJARDIR}/jt400.jar:${PORTSDIR}/sysutils/jtopen
-RUN_DEPENDS=	${JAVAJARDIR}/itext.jar:${PORTSDIR}/devel/itext \
+		${JAVAJARDIR}/jt400.jar:${PORTSDIR}/sysutils/jtopen \
+		${JAVAJARDIR}/itext.jar:${PORTSDIR}/devel/itext \
+		${JAVAJARDIR}/log4j.jar:${PORTSDIR}/devel/log4j
+RUN_DEPENDS=	${JAVAJARDIR}/mail.jar:${PORTSDIR}/java/javamail \
+		${JYTHON_JAR}:${PORTSDIR}/lang/jython \
+		${JAVAJARDIR}/jt400.jar:${PORTSDIR}/sysutils/jtopen \
+		${JAVAJARDIR}/itext.jar:${PORTSDIR}/devel/itext \
  		${JAVAJARDIR}/log4j.jar:${PORTSDIR}/devel/log4j

  USE_ZIP=	yes



-- 
               << Marcin Cieslak // saper at system.pl >>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 273 bytes
Desc: OpenPGP digital signature
Url : http://lists.freebsd.org/pipermail/cvs-ports/attachments/20080614/093cfd68/signature.pgp