cvs commit: ports/mail/libvmime Makefile

Xin LI delphij at delphij.net
Wed Jul 23 10:22:18 UTC 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Pav Lucistnik wrote:
| Xin LI píše v út 22. 07. 2008 v 19:19 -0700:
|> -----BEGIN PGP SIGNED MESSAGE-----
|> Hash: SHA1
|>
|> Pav Lucistnik wrote:
|> | pav         2008-07-23 00:57:45 UTC
|> |
|> |   FreeBSD ports repository
|> |
|> |   Modified files:
|> |     mail/libvmime        Makefile
|> |   Log:
|> |   - Mark BROKEN: does not compile with gnutls-2.4.x
|>
|> Er, why, how can we say this version of gnutls is not broken when they
|> have this?
|>
|> ~  typedef enum gnutls_certificate_print_formats
|> ~    {
|> ~      GNUTLS_CRT_PRINT_FULL,
|> ~      GNUTLS_CRT_PRINT_ONELINE,
|> ~      GNUTLS_CRT_PRINT_UNSIGNED_FULL,   // extra ","
|> ~    } gnutls_certificate_print_formats_t;
|
| I don't mind if it's fixed in libvmime or in gnutls port, as long as it
| get fixed.

Unfortunately this can *NOT* be fixed in libvmime because gnutls's
include file is broken.  By making an instance of
gnutls_certificate_print_formats_t the compiler would notice the problem
immediately.

| BTW it's still this way in gnutls git.

I have submitted ticket #770 on gnutls trac.  Just because it is still
in gnutls git does not mean that it is correct.  Can we fix the (broken)
security/gnutls, rather than mark (the non-broken) libvmime broken?  The
port works just fine with patched gnutls.

Cheers,
- --
Xin LI <delphij at delphij.net>	http://www.delphij.net/
FreeBSD - The Power to Serve!
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (FreeBSD)

iEYEARECAAYFAkiHBisACgkQi+vbBBjt66BeTgCeMuPm7Nl9h7zP7wqiAiup0n9O
LL4AoMBR/B+nCtjd4meHnE8OklIuKAip
=A34Q
-----END PGP SIGNATURE-----
-------------- next part --------------
diff --git a/includes/gnutls/gnutls.h.in b/includes/gnutls/gnutls.h.in
index 13d507b..2025cdb 100644
--- a/includes/gnutls/gnutls.h.in
+++ b/includes/gnutls/gnutls.h.in
@@ -299,7 +299,7 @@ extern "C"
     {
       GNUTLS_CRT_PRINT_FULL,
       GNUTLS_CRT_PRINT_ONELINE,
-      GNUTLS_CRT_PRINT_UNSIGNED_FULL,
+      GNUTLS_CRT_PRINT_UNSIGNED_FULL
     } gnutls_certificate_print_formats_t;
 
   typedef enum


More information about the cvs-ports mailing list