cvs commit: ports/security/vpnc Makefile
ports/security/vpnc/files vpnc.in vpnc.sh
[LoN]Kamikaze
LoN_Kamikaze at gmx.de
Thu Mar 22 10:06:27 UTC 2007
Doug Barton wrote:
> 5. In vpnc_start() you could simplify the code by doing:
>
> if ! $command $current $vpnc_flags; then
> status=$?
> echo "Running 'vpnc $current $vpnc_flags' failed."
> return $status
> fi
That was a really bad idea, because it causes status to always be 0. Which is probably not the right thing to return in case of an error.
More information about the cvs-ports
mailing list