cvs commit: ports/devel/mpatrol Makefile ports/devel/mpatrol/files patch-..::..::src::mptrace.c

[Vasil Dimov]

On Thu, Nov 02, 2006 at 10:50:26PM -0800, Maxim Sobolev wrote:
> Vasil Dimov wrote:
> >On Thu, Nov 02, 2006 at 10:18:50PM -0800, Maxim Sobolev wrote:
> >>Vasil Dimov wrote:
> >>>On Fri, Nov 03, 2006 at 03:51:40AM +0000, Maxim Sobolev wrote:
> >>>>sobomax     2006-11-03 03:51:40 UTC
> >>>[...]
> >>>> Added files:
> >>>>   devel/mpatrol/files  patch-..::..::src::mptrace.c 
> >>>Aargh :-/
> >>>I thought we were supposed to use Tools/scripts/splitpatch.pl for new
> >>>patches.
> >>Why so? We have Tools/scripts/patchtool.py for the few years now.
> >
> >The note I made was about the convention, not the exact tool used. You
> >should read:
> >
> >"I thought we were supposed to use the convention used by
> >Tools/scripts/splitpatch.pl for new patches."
> 
> Who those "we" are and why exactly they should use that "convention"? Is 
> it official or what?

Those "we" are the ones creating new patches for FreeBSD ports and placing
them in files/ subdirectories.

_They_ should use that convention because it is better to have some
convention than no convention at all.

Please read
http://www.freebsd.org/doc/en/books/porters-handbook/slow-patch.html
especially:

"Each patch you wish to apply should be saved into a file named patch-*
where * indicates the pathname of the file that is patched, such as
patch-Imakefile or patch-src-config.h
...
Please only use characters [-+._a-zA-Z0-9] for naming your patches."

I dunno what do you mean by "official" and if you consider the
"Porters Handbook" being "official".

Anyway you can name your patches
patch-@}>-->---ILoveYouMary-src_file.c if you like but you will raise
usless discussions like the current one.

-- 
Vasil Dimov
gro.DSBeerF at dv
%
Be braver -- you can't cross a chasm in two small jumps.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 155 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-ports/attachments/20061103/66544098/attachment.pgp