cvs commit: ports/devel Makefile ports/devel/glib20 Makefile ports/devel/glib20-reference Makefile bsd.gnome-reference.mk

[Erwin Lansing]

On Wed, May 10, 2006 at 05:56:42PM +0200, Jean-Yves Lefort wrote:
> On Wed, 10 May 2006 08:22:27 +0300
> Vasil Dimov <vd at FreeBSD.org> wrote:
> 
> > On Wed, May 10, 2006 at 01:50:54AM +0200, Jean-Yves Lefort wrote:
> > > On Wed, 10 May 2006 09:43:46 +1000
> > > Edwin Groothuis <edwin at mavetju.org> wrote:
> > > 
> > > > On Wed, May 10, 2006 at 01:33:56AM +0200, Jean-Yves Lefort wrote:
> > > > > On Wed, 10 May 2006 09:24:19 +1000
> > > > > Edwin Groothuis <edwin at mavetju.org> wrote:
> > > > > 
> > > > > > On Tue, May 09, 2006 at 10:03:27PM +0000, Jean-Yves Lefort wrote:
> > > > > > > jylefort    2006-05-09 22:03:27 UTC
> > > > > > > 
> > > > > > >   FreeBSD ports repository
> > > > > > > 
> > > > > > >   Modified files:
> > > > > > >     devel                Makefile 
> > > > > > >     devel/glib20         Makefile 
> > > > > > >   Added files:
> > > > > > >     devel/glib20-reference Makefile bsd.gnome-reference.mk 
> > > > > > >   Log:
> > > > > > >   Add glib20-reference and the bsd.gnome-reference.mk framework.
> > > > > > >   
> > > > > > >   Revision  Changes    Path
> > > > > > >   1.2197    +1 -0      ports/devel/Makefile
> > > > > > >   1.1       +16 -0     ports/devel/glib20-reference/Makefile (new)
> > > > > > >   1.1       +53 -0     ports/devel/glib20-reference/bsd.gnome-reference.mk (new)
> > > > > > >   1.122     +5 -0      ports/devel/glib20/Makefile
> > > > > > 
> > > > > > Where are the manditory comment lines in this makefile?
> > > > > 
> > > > > In bsd.gnome-reference.mk.
> > > > 
> > > > I mean the :
> > > > 
> > > > # New ports collection makefile for:   gtk20-apireference
> > > > # Date created:        13 June 2001
> > > > # Whom:                Edwin Groothuis (edwin at mavetju.org)
> > > > #
> > > > # $FreeBSD: ports/x11-toolkits/gtk20-apireference/Makefile,v 1.9 2004/12/15 04:34:53 edwin Exp $
> > > > #
> > > 
> > > Omitted, since it's useless (and not mandatory btw).
> > > 
> > It's not useless since it's nice to see who and when created that file
> 
> That information is available from the CVS repository:
> 
> http://www.freebsd.org/cgi/cvsweb.cgi/glib20-reference/
> 
> > How do you define mandatory?
> 
> Written in imperative form in some document such as the Porter's
> Handbook.
> 
> > From the 14599 Makefiles in the ports collection there is just one
> > which do not have those lines: ports/sysutils/bacula-client/Makefile,
> > yours (devel/glib20-reference/Makefile) is the second one.
> > 
> > Don't think that I trying to tell you what to do, its just my wish to
> > see those lines there.
> 
> My own wish is to get rid of that religious ritual (which is btw
> inconsistent, since various levels of tabulation and various date
> formats are used).
> 

Whether official or unofficial, this has been a policy since the start.
I am not going to info a discussion about if we want to keep that or
not, which doesn't below on these list, but I am objection to your
self-justice by changing existing tradition without prior discussion.
Please add the header to the Makefile and start a discussion on the
right mailinglist.

-erwin

-- 
Erwin Lansing                                     http://droso.org
Security is like an onion.          (o_ _o)
It's made up of several layers   \\\_\   /_///    erwin at FreeBSD.org
And it makes you cry.            <____) (____>    erwin at aauug.dk
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-ports/attachments/20060510/c11792d5/attachment.pgp