cvs commit: ports/Mk bsd.port.mk
Sergey Matveychuk
sem at FreeBSD.org
Fri Jun 30 10:36:50 UTC 2006
Joe Marcus Clarke wrote:
> Sergey Matveychuk wrote:
>>> Joe Marcus Clarke wrote:
>>>> On Thu, 2006-06-29 at 11:34 +0400, Sergey Matveychuk wrote:
>>>>> Joe Marcus Clarke wrote:
>>>>>> This, of course, would not cause the error. As I said to Mark in a
>>>>>> follow-up email, it may very well be time to retire DEPENDS, but the
>>>>>> patch that was committed did not successfully do that and maintain the
>>>>>> buildability of the tree.
>>>>>>
>>>>> Using FORCE_PKG_REGISTER inside bsd.port.mk is is hacky and wrong.
>>>>> I think we can make up a better solution for the problem with kdehier.
>>>>> I'll think for it on this weekend.
>>>> There are other solutions. See gnomehier, for example. It's not just
>>>> kdehier, though. Anything that uses DEPENDS would have been broken.
>>>>
>>> A little number really:
>>> % find . -name Makefile -exec grep ^DEPENDS= {} /dev/null \;
>>> ./audio/klira/Makefile:DEPENDS= ${PORTSDIR}/misc/kdehier
>>> ./lang/pm3-forms/Makefile:DEPENDS= ${PORTSDIR}/lang/pm3-base:build
>>> ./www/caudium12/Makefile:DEPENDS= ${PORTSDIR}/lang/pexts/
>>> ./x11/kdelibs3/Makefile:DEPENDS= ${PORTSDIR}/misc/kdehier
>>>
>>> pm3-forms does no harm (just build target).
>>> DEPENDS in it and in caudium12 can be changed with
>>> BUILD_DEPENDS/RUN_DEPENDS easily.
>>>
>>> May be it's time to get rid of obsoleted DEPENDS?
>
> I have no objection, but the patch would need to be more complete than
> the previous one.
Sure. It will.
--
Dixi.
Sem.
More information about the cvs-ports
mailing list