cvs commit: ports/japanese/xdtp Makefile

[Kris Kennaway]

On Thu, Oct 20, 2005 at 10:24:53AM +0200, Volker Stolz wrote:
> On Thu, Oct 20, 2005 at 04:13:05AM -0400, Kris Kennaway wrote:
> > > > >   . compile with -fPIC, this fixes build on amd64
> > > > 
> > > > Please don't pessimize all architectures like this.  You shouldn't
> > > > even be pessimizing all files on amd64 with this flag, only those that
> > > > need them.
> > > 
> > > Is this really such a strong pessimisation?
> > > http://www.ukuug.org/events/linux2002/papers/pdf/dsohowto.pdf
> > > "How To Write Shared Libraries" claims that this is almost a non-issue.
> > > (Please rub my nose the archives I missed any discussion about the pros/cons.)
> > 
> > I don't know how much of an issue it is, but there's no reason not to
> > do it correctly.
> 
> Increasing the number of conditionals in a port is another form of
> pessimisation in my book.
>
> Maybe this could be done globally for CFLAGS on amd64?

As I said, the correct thing to do is to patch the vendor sources to
only add -fPIC to those compilations that require it (shared library
objects).

Whether or not it's usually a significant runtime pessimization, in
FreeBSD we don't take the lazy way out.

Kris
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-ports/attachments/20051020/e6e2ddc1/attachment.bin