cvs commit: ports/misc/vifm Makefile distinfo

Stefan Walter sw at gegenunendlich.de
Wed Aug 31 09:41:11 GMT 2005


Renato Botelho, 30.08.05, 18:03h CEST:

> > The changes you made also added a new call of REINPLACE_CMD that wasn't in
> > my patch. I (the maintainer) wasn't asked or notified about it at all, and
> > it doesn't even show up in the commit log. What's the purpose of the added
> > call, and why wasn't I asked before it was committed?
> 
> After apply your patch the port stops to build on FreeBSD-4.x, so, I
> made this change just to fix the build.
> 
> Anyway, sorry about the mistake.

OK. Thanks for the fix, I couldn't test it on RELENG_4 and thus wasn't
aware of the problem. But please get some feedback before committing
changes to a port which has a maintainer, as that's the person people turn
to if something's wrong, especially after an update.

Regards,
Stefan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 650 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-ports/attachments/20050831/ddbf30b2/attachment.bin


More information about the cvs-ports mailing list