cvs commit: ports/x11/kdebase3 Makefile pkg-message ports/x11/kdebase3/files pkg-message

[Michael Nottebrock]

On Sunday 02 May 2004 19:13, David O'Brien wrote:
> On Sun, May 02, 2004 at 06:10:50AM -0700, Michael Nottebrock wrote:
> > lofi        2004/05/02 06:10:50 PDT
> >
> >   FreeBSD ports repository
> >
> >   Modified files:
> >     x11/kdebase3         Makefile
> >   Added files:
> >     x11/kdebase3/files   pkg-message
> >   Removed files:
> >     x11/kdebase3         pkg-message
> >   Log:
> >   Process the pkg-message template earlier than post-install so
> >   package users will actually get to see it the right way.
> >
> >   PR: ports/66123
> >   Reported by: obrien
>
> Thank you for fixing this, but why didn't you just leave pkg-message
> where it was?  Just because it needs fixing up it doesn't have to live in
> the non-standard files/ directory.  Please consider moving that and the
> plists back to the main kdebase3 directory.

I don't think a pkg-message that really isn't one but a template that needs to 
be processed first should be visible, so I'd rather hide it in ${FILESDIR}. 
Perhaps I should have renamed it to message-template? Also, our plist bits 
aren't standard plists (the real plist is concatenated from them, depending 
on build options) and thus don't belong into the portdir, but into 
${FILESDIR}.

-- 
   ,_,   | Michael Nottebrock               | lofi at freebsd.org
 (/^ ^\) | FreeBSD - The Power to Serve     | http://www.freebsd.org
   \u/   | K Desktop Environment on FreeBSD | http://freebsd.kde.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: signature
Url : http://lists.freebsd.org/pipermail/cvs-ports/attachments/20040502/8e510909/attachment.bin