cvs commit: ports/math/gnuplot Makefile
pav at FreeBSD.org
Sun Jun 27 17:02:08 PDT 2004
V po, 28. 06. 2004 v 01:52, Greg Lewis píše:
> > FreeBSD ports repository
> > Modified files:
> > math/gnuplot Makefile
> > Log:
> > Fix OPTIONS
> > PR: ports/68388
> > Submitted by: Ports Fury
> So, what exactly is wrong with doing
> .if defined(WITH_OPTION)
> other stuff
> .if defined(WITHOUT_OPTION)
> other stuff
> fixes? The only thing I can think of is that it may be prefered to test the
> WITHOUT_OPTION variable when the default is on. Is that it?
In the unattended build, when no OPTIONS dialog is displayed, you don't
have any WITH* and WITHOUT* variables set. Your port should behave as if
default values were selected.
OPTIONS= OPTION "foo" on
Default is to have OPTION on. When no WITH/WITHOUT* variables are
generated, your test
will fail. That's now the default you wanted. If you check instead
it will work correctly in case OPTIONS were not processed. This nicely
demonstrates in unattended build on packages on Bento, for example.
> Also, why wasn't the PR assigned to the maintainer (me :)?
Ask krion :)
Pav Lucistnik <pav at oook.cz>
<pav at FreeBSD.org>
lofi> My _sympathetic_ opinion about kdevelop is that it's a huge pile
of shit that might at least work okay if used in Linux.
lofi> My neutral opinion is that it's just a huge pile of shit.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 187 bytes
Desc: Toto je =?iso-8859-2?Q?digit=E1ln=EC?=
Url : http://lists.freebsd.org/pipermail/cvs-ports/attachments/20040628/2feeb790/attachment-0001.bin
More information about the cvs-ports