cvs commit: ports/devel/portlint Makefile ports/devel/portlint/src portlint.pl

[Joe Marcus Clarke]

On Sun, 2004-06-06 at 03:56, Oliver Eikemeier wrote:
> Joe Marcus Clarke wrote:
> 
> >   * Check distinfo to make sure each file in DISTFILES has SIZE and MD5 entries
> >     if NO_SIZE and NO_CHECKSUM are not defined
> 
> I believe this change serves no useful purpose and should be undone:
> 
> - no rule mandates the use of SIZE in distfiles. `make makesum' adds it by default,
>   so if it is missing it is removed on purpose, e.g. to account for an mirror that
>   has an broken http server.
> 
> - the patch does not check PATCHFILES
> 
> - the check fails for DISTFILES that use :group notation
> 
> - bsd.port.mk already checks whether distinfo is consitent in terms of existing MD5
>   lines, no point in repeating this check in portlint
> 
> - the patch mandates SIZE lines for distfiles which are added to IGNOREFILES and have
>   MD5 (...) = IGNORE, which makes no sense.
> 
> Generally patches like this should be checked with portlintgrep to see what ports
> they flag, and whether they solve an existing or potential problem in the ports tree.

This was supposed to solve a problem that I've personally hit a few
times.  It was just another check to make sure PKGNAME agrees with what
is in distinfo.  At one time, I was thinking about PATCHFILES and the
:group stuff, but I rushed 2.6.3 out for the sake of the deprecated
macros.

In the meantime, I've reverted the changes until I can make them work
for the majority of cases.

Joe

> 
> -Oliver
-- 
Joe Marcus Clarke
FreeBSD GNOME Team	::	gnome at FreeBSD.org
FreeNode / #freebsd-gnome
http://www.FreeBSD.org/gnome
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: This is a digitally signed message part
Url : http://lists.freebsd.org/pipermail/cvs-ports/attachments/20040606/9c34ac5c/attachment.bin