cvs commit: ports/mail/libesmtp Makefile
fjoe at FreeBSD.org
Mon Jan 19 01:24:16 PST 2004
On Mon, Jan 19, 2004 at 11:02:59PM -0800, John Merryweather Cooper wrote:
> I was away in Seattle, so viewing the code was a might difficult. Now
> that I'm back home, I have to agree that the internal memrchr() fix
> better preserves the semantics of RFC 2818 (which parses from tail to head).
> I wonder since we have both a strchr() and a strrchr() in libc why this
> is not echoed with memchr() and a memrchr() since these functions are so
memrchr() is not mentioned in any standards and is GNU libc extension.
Adding memrchr to libc might be a good idea though.
> Also, the implementation of memrchr() seems to make some very
> i386-specific assumptions about pointers. Couldn't this be better
> implemented wrapping strrchr() to handle NUL and size_t?
Please point out which i386-specific assumptions are made (I do not see any)
so we can fix them. memrchr could not be mapped to our strrchr()
implementation (please take a look at how it is implemented there).
More information about the cvs-ports