cvs commit: ports/audio/grip Makefile ports/audio/easytag Makefile

Adam Weinberger adamw at FreeBSD.org
Sat Jan 3 15:50:03 PST 2004


>> (01.03.2004 @ 1735 PST): Edwin Groothuis said, in 1.2K: <<
> On Sat, Jan 03, 2004 at 05:26:39PM -0500, Adam Weinberger wrote:
> > >> (01.03.2004 @ 1720 PST): Edwin Groothuis said, in 0.6K: <<
> > > edwin       2004/01/03 14:20:29 PST
> > > 
> > >   FreeBSD ports repository
> > > 
> > >   Modified files:
> > >     audio/grip           Makefile 
> > >     audio/easytag        Makefile 
> > >   Log:
> > >   Chase version change of audio/id3lib, forgotten yesterday due to
> > >   missing space:
> > >           for i in easytaggrip gtkpod id3v2 juk squash xmms-f...
> > >   
> > >   PR:             ports/60830
> > >   Submitted by:   Roman Shterenzon <roman at xpert.com>
> > >   Reviewed by:    Adam Weinberger <adamw at FreeBSD.org>
> > >> end of "cvs commit: ports/audio/grip Makefile ports/audio/easytag Makefile" from Edwin Groothuis <<
> > 
> > I don't recall reviewing this commit, Edwin. Given your recent commits,
> > I don't want my name attributed to your updates unless I actually did
> > what you claim I do.
> 
> Oh puh-lease. Did or didn't you send the email regarding the previous
> commit? That's what I call review.
> 
> Edwin, going away on a holiday for a long time, feel free to fix
> my updates and ports where needed.
>> end of "Re: cvs commit: ports/audio/grip Makefile ports/audio/easytag Makefile" from Edwin Groothuis <<

No, edwin. That's NOT review. Review is when you send me a diff, and I
let you know whether or not it's ok. What I did was send you an email
letting you know that, once again, you fucked up other ports with your
carelessness.

Frankly, review is exactly what you should be seeking, as you've made it
crystal clear that you're either unable or unwilling to perform any sort
of self-review of the commits you make.

And now, of course, you're just leaving it for others to clean up your
mess. Again.

And that, edwin, is why I don't want you to pretend that I review your
work in any way. I in no way own your mistakes.

# Adam


--
Adam Weinberger
vectors.cx	>>  adam at vectors.cx	>>  http://www.vectors.cx
magnesium.net	<<  adamw at magnesium.net	<<  http://www.magnesium.net/~adamw
FreeBSD		>>  adamw at FreeBSD.org	>>  http://people.freebsd.org/~adamw
#vim:set ts=8: 8-char tabs prevent tooth decay.


More information about the cvs-ports mailing list